-
Notifications
You must be signed in to change notification settings - Fork 943
Fix a memory leak in DnsOverTcpTest
#6206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Motivation: A memory leak was detected while running `DnsOverTcpTest`. Related: netty/netty#15033 Modifications: - Forked `TcpDnsQueryDecoder` and applied a patch to fix the memory leak. Result: Stabilize CI builds
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6206 +/- ##
============================================
+ Coverage 74.46% 74.64% +0.18%
- Complexity 22234 22473 +239
============================================
Files 1963 1972 +9
Lines 82437 82992 +555
Branches 10764 10798 +34
============================================
+ Hits 61385 61950 +565
+ Misses 15918 15897 -21
- Partials 5134 5145 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I understand that we don't need to release another patch because no one uses Armeria as a DNS server.
core/src/test/java/com/linecorp/armeria/client/endpoint/dns/TcpDnsQueryDecoder.java
Show resolved
Hide resolved
Right. This is a memory leak fix in the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Motivation:
A memory leak was detected while running
DnsOverTcpTest
. Related: netty/netty#15033Modifications:
TcpDnsQueryDecoder
and applied a patch to fix the memory leak.Result:
Stabilize CI builds