Skip to content

Fix a memory leak in DnsOverTcpTest #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Apr 15, 2025

Motivation:

A memory leak was detected while running DnsOverTcpTest. Related: netty/netty#15033

Modifications:

  • Forked TcpDnsQueryDecoder and applied a patch to fix the memory leak.

Result:

Stabilize CI builds

Motivation:

A memory leak was detected while running `DnsOverTcpTest`.
Related: netty/netty#15033

Modifications:

- Forked `TcpDnsQueryDecoder` and applied a patch to fix the memory leak.

Result:

Stabilize CI builds
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (8150425) to head (b0c1cbd).
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6206      +/-   ##
============================================
+ Coverage     74.46%   74.64%   +0.18%     
- Complexity    22234    22473     +239     
============================================
  Files          1963     1972       +9     
  Lines         82437    82992     +555     
  Branches      10764    10798      +34     
============================================
+ Hits          61385    61950     +565     
+ Misses        15918    15897      -21     
- Partials       5134     5145      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I understand that we don't need to release another patch because no one uses Armeria as a DNS server.

@ikhoon
Copy link
Contributor Author

ikhoon commented Apr 16, 2025

Thanks! I understand that we don't need to release another patch because no one uses Armeria as a DNS server.

Right. This is a memory leak fix in the test.

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ikhoon ikhoon merged commit 3a35abe into line:main Apr 17, 2025
15 of 16 checks passed
@ikhoon ikhoon deleted the fix-tcp-dns-leak branch April 17, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants