Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieClient appends cookies with the same name #5870

Open
ohadgur opened this issue Aug 12, 2024 · 0 comments
Open

CookieClient appends cookies with the same name #5870

ohadgur opened this issue Aug 12, 2024 · 0 comments
Labels
Milestone

Comments

@ohadgur
Copy link
Contributor

ohadgur commented Aug 12, 2024

Hi team, I moved the question from discord.
I started using the CookieClient decorator to honor set-cookie headers in the server's response.

I noticed that if the server keeps returning the same cookie name, domain, and path, but a different value, the cookies on the next request are concatenated. This seems like a bug looking at https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.2

This causes the server (non-armeria) to fail the requests since they are getting too big.

I created a small reproducer here - https://gist.github.com/ohadgur/4c10c14b50fc742cffff883237362e07

Thanks!

@ikhoon ikhoon added the defect label Aug 12, 2024
@ikhoon ikhoon added this to the 1.31.0 milestone Aug 12, 2024
@jrhee17 jrhee17 modified the milestones: 1.31.0, 1.32.0 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants