From 6af3a6c9b89762f8e4d3b8a425f33b52c86652a3 Mon Sep 17 00:00:00 2001 From: Ikhun Um Date: Thu, 21 Nov 2024 14:49:51 +0900 Subject: [PATCH] Fix Jacoco failure (#5994) Motivation: ``` Caused by: java.lang.IllegalStateException: Can't add different class with same name: com/linecorp/armeria/common/logback/LoggingEventWrapper at org.jacoco.core.analysis.CoverageBuilder.visitCoverage(CoverageBuilder.java:106) at org.jacoco.core.analysis.Analyzer$1.visitEnd(Analyzer.java:100) at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395) at org.jacoco.core.internal.flow.ClassProbesAdapter.visitEnd(ClassProbesAdapter.java:100) at org.objectweb.asm.ClassReader.accept(ClassReader.java:749) at org.objectweb.asm.ClassReader.accept(ClassReader.java:425) at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:117) at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:133) ... 152 more ``` Modifications: - Set `no_aggregation` flag to `:it:logback1.5` Result: Fixes #5989 --- settings.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle b/settings.gradle index e5ecc716ad6..64a00b3b1af 100644 --- a/settings.gradle +++ b/settings.gradle @@ -219,7 +219,7 @@ includeWithFlags ':it:jackson-provider', 'java', 'relocate includeWithFlags ':it:kotlin', 'java', 'relocate', 'kotlin' includeWithFlags ':it:kubernetes-chaos-tests', 'java', 'relocate' includeWithFlags ':it:logback1.4', 'java11', 'relocate' -includeWithFlags ':it:logback1.5', 'java11', 'relocate' +includeWithFlags ':it:logback1.5', 'java11', 'relocate', 'no_aggregation' includeWithFlags ':it:multipart', 'java17', 'relocate' includeWithFlags ':it:nio', 'java', 'relocate' includeWithFlags ':it:okhttp', 'java', 'relocate'