Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move counting routines to estimator class #25

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

camposandro
Copy link
Contributor

The correlation counts depend on the estimator selected. This pull request creates the Estimator abstract class and adds the counting routine as its method. Currently there is just the implementation for the natural estimator (DD/RR - 1). The remaining ones will be added according to #23. Closes #24.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Jul 12, 2024
@camposandro camposandro force-pushed the issue/24/estimator-based-counts branch from 787903d to 99c3c13 Compare July 12, 2024 21:16
Copy link

github-actions bot commented Jul 12, 2024

Before [a21b9aa] After [a6448ea] Ratio Benchmark (Parameter)
4.15±0.5s 2.57±0.9s ~0.62 benchmarks.time_computation
3.94k 2.1k 0.53 benchmarks.mem_list

Click here to view all benchmarks.

@camposandro camposandro marked this pull request as ready for review July 12, 2024 21:21
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/corrgi/correlation/angular_correlation.py 100.00% <100.00%> (ø)
src/corrgi/correlation/projected_correlation.py 100.00% <100.00%> (ø)
src/corrgi/corrgi.py 91.66% <100.00%> (-2.09%) ⬇️
src/corrgi/dask.py 72.97% <ø> (-2.64%) ⬇️
src/corrgi/estimators/natural_estimator.py 100.00% <100.00%> (ø)
src/corrgi/correlation/correlation.py 87.75% <80.00%> (-0.89%) ⬇️
src/corrgi/estimators/estimator.py 96.77% <96.77%> (ø)
src/corrgi/estimators/estimator_factory.py 90.00% <90.00%> (ø)
src/corrgi/correlation/redshift_correlation.py 0.00% <0.00%> (ø)

@camposandro camposandro mentioned this pull request Jul 17, 2024
5 tasks
@camposandro camposandro requested a review from delucchi-cmu July 17, 2024 15:07
@camposandro camposandro merged commit 39e15e9 into main Jul 18, 2024
7 checks passed
@camposandro camposandro deleted the issue/24/estimator-based-counts branch July 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong type of counts according to the correlation estimator
2 participants