[Plan B] TF-2764 Printing pdf when preview #2780

dab246 · 2024-04-04T09:39:46Z

Issue

#2764

Task

Preview PDF file on all browser
Download PDF file on all browser
Printing PDF file on all browser (but file names are randomly generated from the respective browser)
- Firefox: PDF.js Viewer
- Safari: Twake Mail
- Edge: index
- Opera: FileName or UUID
- Chrome: FileName or UUID
Show current page, total page in PDFViewer
Zoom in/Zoom out in PDF Viewer

Demo

Screen.Recording.2024-04-04.at.16.35.30.online-video-cutter.com.mp4

hoangdat · 2024-04-05T07:15:02Z

Brief about this proposal: View one-by-one PDF in Dart side in only Web app

Download PDF file
Open PDF with https://pub.dev/packages/syncfusion_flutter_pdfviewer
Viewer will stay overlay in web app tab (same with gmail)
Add actions: Download, Print, Zoom In/Out, Jump page in viewer
But downside note: print still not have a exactly name

Hi @chibenwa what do you think with this proposal (we were in progress while you sent email about revert PDF viewer). And for sure, we need to verify very carefully in all OS and browser.

core/lib/presentation/views/file_viewer/pdf_viewer.dart

core/lib/presentation/views/file_viewer/pagination_pdf_viewer.dart

github-actions · 2024-04-15T02:18:04Z

This PR has been deployed to https://linagora.github.io/tmail-flutter/2780.

hoangdat · 2024-05-07T09:37:39Z

the same page maybe reload many times when trying to scroll document

Screen.Recording.2024-05-07.at.16.36.16.mov

hoangdat · 2024-05-07T09:42:16Z

Chrome:

print big file maybe we should show popup to indicate user
scroll document will skip some pages: Fx: document have 3 pages, can not scroll to page 2

hoangdat · 2024-05-07T09:54:21Z

try to open 2 documents in the same time, document 1 will show well, but document 2 can not load

Screen.Recording.2024-05-07.at.16.51.24.mov

dab246 · 2024-05-07T09:57:29Z

try to open 2 documents in the same time, document 1 will show well, but document 2 can not load

Screen.Recording.2024-05-07.at.16.51.24.mov

We should only have 1 page at a time, preventing opening multiple pages at a time.

dab246 · 2024-05-07T09:58:50Z

Chrome:

print big file maybe we should show popup to indicate user

IMO, We just need to show the toast, which is enough for the user to understand, to avoid blocking other user actions.

hoangdat · 2024-05-07T10:53:57Z

Firefox:

Name of print file in Firefox wrong

dab246 · 2024-05-13T08:32:18Z

Chrome:

print big file maybe we should show popup to indicate user

try to open 2 documents in the same time, document 1 will show well, but document 2 can not load

Screen.Recording.2024-05-07.at.16.51.24.mov

Solution

Perform download attachment in PDF Viewer

Demo

Screen.Recording.2024-05-13.at.15.07.18.mov

dab246 · 2024-05-14T10:06:48Z

the same page maybe reload many times when trying to scroll document

scroll document will skip some pages: Fx: document have 3 pages, can not scroll to page 2

Solution

Use pdf_render to cache data when scroll page in PDF Viewer instead of syncfusion_flutter_pdfviewer

Demo

Screen.Recording.2024-05-14.at.16.36.42.online-video-cutter.com.mp4

core/lib/presentation/views/text/text_form_field_builder.dart

lib/features/email/presentation/controller/single_email_controller.dart

test/features/email/presentation/controller/single_email_controller_test.dart

pubspec.yaml

dab246 · 2024-05-16T03:15:53Z

Memory leak
Disable go to page
Set the standard size for the page

hoangdat · 2024-05-17T04:34:06Z

hi @chibenwa please take a look on demo video, and read the ADR.

At the moment, we still have some things:

Print name when people try to print, PDF file is ugly. Try many ways, but can not fix (but the download work well)
Can not jump to page. We can, but to have this we need to trade off with full screen size document.
Can not scroll by dragging on scroll bar in right screen. But right now, still scroll by mouse.

hoangdat · 2024-05-19T23:41:12Z

Hi @chibenwa , hope this find you well #2780 (comment)

chibenwa · 2024-05-21T10:36:46Z

Cool.

Proposal: Escape to exit the PDF viewer?

chibenwa · 2024-05-21T10:41:58Z

Chromium: when printing and "save as pdf" the filename is a UUID

Direct download from the pdf viewer is OK

chibenwa · 2024-05-21T10:58:01Z

Also on GMail when I click on the grey zone around the PDF document, it closes the document.

hoangdat · 2024-05-22T02:01:25Z

Download is ok
file name in printing is wrong in Edge, Firefox, Safari is pdf.js viewer -> Should hide this button in these browsers
click to outside of document or Esc keyboard -> close viewer

dab246 · 2024-05-22T09:33:54Z

Download is ok

file name in printing is wrong in Edge, Firefox, Safari is pdf.js viewer -> Should hide this button in these browsers

click to outside of document or Esc keyboard -> close viewer

Done. @hoangdat Please review again.

Chrome browser:

Screen.Recording.2024-05-22.at.16.20.03.mov

Firefox browser:

firefox.mov

dab246 requested a review from hieutbui April 4, 2024 09:39

dab246 had a problem deploying to PR-2780 April 4, 2024 09:39 — with GitHub Actions Failure

dab246 requested review from nqhhdev, tddang-linagora, sherlockvn and hoangdat April 4, 2024 09:39

dab246 had a problem deploying to PR-2780 April 5, 2024 05:01 — with GitHub Actions Failure

tddang-linagora requested changes Apr 12, 2024

View reviewed changes

core/lib/presentation/views/file_viewer/pdf_viewer.dart Outdated Show resolved Hide resolved

core/lib/presentation/views/file_viewer/pagination_pdf_viewer.dart Outdated Show resolved Hide resolved

dab246 temporarily deployed to PR-2780 April 15, 2024 02:07 — with GitHub Actions Inactive

dab246 requested a review from tddang-linagora April 15, 2024 02:08

tddang-linagora approved these changes Apr 15, 2024

View reviewed changes

dab246 temporarily deployed to PR-2780 April 15, 2024 02:38 — with GitHub Actions Inactive

dab246 changed the base branch from v0.11.3-patch4-dev to master May 8, 2024 04:08

dab246 force-pushed the maintain-v0.11.3/tf-2764-plan-b-for-printing-pdf branch from ef71a66 to 7b190a2 Compare May 8, 2024 04:22

dab246 temporarily deployed to PR-2780 May 8, 2024 04:22 — with GitHub Actions Inactive

dab246 force-pushed the maintain-v0.11.3/tf-2764-plan-b-for-printing-pdf branch from bb5083e to 9ccca88 Compare May 15, 2024 03:19

dab246 temporarily deployed to PR-2780 May 15, 2024 03:19 — with GitHub Actions Inactive

hoangdat reviewed May 15, 2024

View reviewed changes

dab246 temporarily deployed to PR-2780 May 16, 2024 05:04 — with GitHub Actions Inactive

dab246 temporarily deployed to PR-2780 May 17, 2024 03:02 — with GitHub Actions Inactive

dab246 requested a review from hoangdat May 17, 2024 03:02

hoangdat approved these changes May 17, 2024

View reviewed changes

hoangdat had a problem deploying to prod May 21, 2024 07:11 — with GitHub Actions Error

hoangdat temporarily deployed to prod May 21, 2024 07:11 — with GitHub Actions Inactive

hoangdat mentioned this pull request May 21, 2024

View PDF should preserve filename #2737

Closed

dab246 force-pushed the maintain-v0.11.3/tf-2764-plan-b-for-printing-pdf branch from f03b6a3 to 4043bbc Compare May 22, 2024 09:32

dab246 temporarily deployed to PR-2780 May 22, 2024 09:32 — with GitHub Actions Inactive

dab246 requested a review from hoangdat May 22, 2024 09:34

dab246 added 8 commits May 27, 2024 09:33

TF-2764 Enable preview PDF attachment on web platform

a875f0b

TF-2764 Add CancelToken to download attachment for web

3ace408

TF-2764 Add PDFViewer to preview PDF attachment

cd172be

TF-2764 Remove ViewAttachmentForWebInteractor

2e0da39

TF-2764 Add adr for preview PDF in EmailView

ee5aae3

TF-2764 Hide printing button in browsers (Firefox/Safari/Edge)

83d7865

TF-2764 Support click to outside of document to close viewer

9de5291

TF-2764 Support press Escape shortcut key on keyboard to close viewer

d6b9cd2

dab246 force-pushed the maintain-v0.11.3/tf-2764-plan-b-for-printing-pdf branch from 4043bbc to d6b9cd2 Compare May 27, 2024 02:34

dab246 deployed to PR-2780 May 27, 2024 02:34 — with GitHub Actions View deployment

hoangdat approved these changes May 30, 2024

View reviewed changes

hoangdat merged commit 652f15e into master May 30, 2024
14 checks passed

dab246 mentioned this pull request Oct 24, 2024

[EDGE] print button disappears immediately upon openin a PDF file #3225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Plan B] TF-2764 Printing pdf when preview #2780

[Plan B] TF-2764 Printing pdf when preview #2780

dab246 commented Apr 4, 2024 •

edited

Loading

hoangdat commented Apr 5, 2024

github-actions bot commented Apr 15, 2024

hoangdat commented May 7, 2024 •

edited

Loading

hoangdat commented May 7, 2024 •

edited

Loading

hoangdat commented May 7, 2024

dab246 commented May 7, 2024

dab246 commented May 7, 2024

Chrome:

hoangdat commented May 7, 2024

dab246 commented May 13, 2024

Chrome:

dab246 commented May 14, 2024 •

edited

Loading

dab246 commented May 16, 2024

hoangdat commented May 17, 2024

hoangdat commented May 19, 2024

chibenwa commented May 21, 2024

chibenwa commented May 21, 2024

chibenwa commented May 21, 2024

hoangdat commented May 22, 2024 •

edited by dab246

Loading

dab246 commented May 22, 2024

[Plan B] TF-2764 Printing pdf when preview #2780

[Plan B] TF-2764 Printing pdf when preview #2780

Conversation

dab246 commented Apr 4, 2024 • edited Loading

Issue

Task

Demo

hoangdat commented Apr 5, 2024

github-actions bot commented Apr 15, 2024

hoangdat commented May 7, 2024 • edited Loading

hoangdat commented May 7, 2024 • edited Loading

Chrome:

hoangdat commented May 7, 2024

dab246 commented May 7, 2024

dab246 commented May 7, 2024

Chrome:

hoangdat commented May 7, 2024

Firefox:

dab246 commented May 13, 2024

Chrome:

Solution

Demo

dab246 commented May 14, 2024 • edited Loading

Solution

Demo

dab246 commented May 16, 2024

hoangdat commented May 17, 2024

hoangdat commented May 19, 2024

chibenwa commented May 21, 2024

chibenwa commented May 21, 2024

chibenwa commented May 21, 2024

hoangdat commented May 22, 2024 • edited by dab246 Loading

dab246 commented May 22, 2024

dab246 commented Apr 4, 2024 •

edited

Loading

hoangdat commented May 7, 2024 •

edited

Loading

hoangdat commented May 7, 2024 •

edited

Loading

dab246 commented May 14, 2024 •

edited

Loading

hoangdat commented May 22, 2024 •

edited by dab246

Loading