🐛 Fix url escape for arweave key

likecoin · Jan 27, 2025 · cdbba62 · cdbba62
1 parent 834ac5a
commit cdbba62
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/components/IscnRegisterForm.vue b/components/IscnRegisterForm.vue
@@ -973,19 +973,9 @@ export default class IscnRegisterForm extends Vue {
       ?.filter((items: any) => items.filename && items.url)
       ?.map((sameAs: { filename: any; filetype: any; url: any }) => {
         if (sameAs.filename && sameAs.filetype) {
-          try {
-            const parsed = new URL(sameAs.url)
-            parsed.searchParams.set('name', `${sameAs.filename}.${sameAs.filetype}`)
-            return parsed.toString()
-          } catch (e) {
-            // eslint-disable-next-line no-console
-            console.error(e)
-            const parts = sameAs.url.split('?')
-            if (parts.length === 1) {
-              return `${sameAs.url}?name=${sameAs.filename}.${sameAs.filetype}`
-            }
-            return `${sameAs.url}&name=${sameAs.filename}.${sameAs.filetype}`
-          }
+          const parsed = new URL(sameAs.url)
+          parsed.searchParams.set('name', `${sameAs.filename}.${sameAs.filetype}`)
+          return parsed.toString()
         }
         return ''
       })

diff --git a/pages/edit/_iscnId.vue b/pages/edit/_iscnId.vue
@@ -338,7 +338,9 @@ export default class EditIscnPage extends Vue {
       return this.sameAsList.map(
         (sameAs: { filename: any; filetype: any; url: any }) => {
           if (sameAs.filename && sameAs.filetype) {
-            return `${sameAs.url}?name=${sameAs.filename}.${sameAs.filetype}`
+            const url = new URL(sameAs.url)
+            url.searchParams.set('name', `${sameAs.filename}.${sameAs.filetype}`)
+            return url.toString()
           }
           return ''
         },

diff --git a/utils/ui.js b/utils/ui.js
@@ -52,7 +52,9 @@ export function formatIpfs(ipfsHash) {
 
 export function formatArweave(arweaveId, key) {
   if (key) {
-    return `ar://${arweaveId}?key=${key}`
+    const url = new URL(`ar://${arweaveId}`);
+    url.searchParams.append('key', key);
+    return url.toString();
   }
   return `ar://${arweaveId}`
 }