Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing a client object and allow operations to be an any callable Lua object #13

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Oct 18, 2024

No description provided.

@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11444458450

Details

  • 17 of 22 (77.27%) changed or added relevant lines in 2 files are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-5.6%) to 85.491%

Changes Missing Coverage Covered Lines Changed/Added Lines %
molly/utils.lua 11 12 91.67%
molly/client.lua 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
molly/utils.lua 1 84.38%
molly/runner.lua 3 92.31%
molly/tests.lua 11 66.23%
molly/client.lua 23 55.42%
Totals Coverage Status
Change from base Build 9826004009: -5.6%
Covered Lines: 548
Relevant Lines: 641

💛 - Coveralls

@ligurio ligurio force-pushed the ligurio/gh-xxxx-op-is-callable branch 3 times, most recently from 2c2c70b to 6b56d89 Compare October 21, 2024 15:51
@ligurio ligurio force-pushed the ligurio/gh-xxxx-op-is-callable branch 2 times, most recently from 61c5f86 to 7af0c05 Compare October 21, 2024 16:21
Sometimes operations should contain not a constant values,
but a something calculated in runtime. In such cases
`op` can be a Lua function or any callable object, i.e. Lua object
with defined `__call` metamethod.
@ligurio ligurio force-pushed the ligurio/gh-xxxx-op-is-callable branch from 7af0c05 to e0791d3 Compare October 21, 2024 16:24
@ligurio ligurio changed the title Fix passing a client object Fix passing a client object and allow operations to be an any callable Lua object Oct 21, 2024
@ligurio ligurio merged commit ba0fe40 into master Oct 21, 2024
7 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-op-is-callable branch October 21, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants