-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itest: properly document the known flakes #9582
base: master
Are you sure you want to change the base?
Conversation
We now use dedicated methods to properly document the flakes in *one* place.
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Remove an old TODO, which has been fixed with the `NoWait` flag for coop close.
Hence finish an old TODO.
As they are fixed now.
The first commit fixes the flake found from this build,
The rest of the commits are documentations - we want to have one place documenting all the flaky behavior, plus to remind us these need to be fixed. For any future attempt to temporary mitigate a flake, we should always document it in details - which means we should at least describe the possible cause, and how to fix or where to investigate.