sweepbatcher: always enabled mixed batches #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
always-mixed-batches
branch
from
15b73a5 to
8413f80
Compare
Mixed batches approach covers the case where all the inputs are cooperative (function publishBatchCoop) and it is better than fully non-cooperative case (function publishBatch), but it can also create such transaction if needed, i.e. if all the sweeps are non-cooperative. So we can remove functions publishBatch, publishBatchCoop, option WithMixedBatch and associated code in greedy batch selection algorithm.
starius
force-pushed
the
always-mixed-batches
branch
from
8413f80 to
2c38de1
Compare
hieblmi
approved these changes
Feb 6, 2025
@hieblmi yes, the mixed batcher is a generalized coop-batcher and it is also a generalized noncoop-batcher. It can produce both these variants when possible/needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixed batches approach covers the case where all the inputs are cooperative (function
publishBatchCoop) and it is better than fully non-cooperative case (functionpublishBatch), but it can also create such transaction if needed, i.e. if all the sweeps are non-cooperative. So we can remove functionspublishBatch,publishBatchCoop, optionWithMixedBatchand associated code in greedy batch selection algorithm.This simplifies the code ahead of the upcoming changes.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes