script: static address taproot script #690
Conversation
staticaddr/script/script_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func MuSig2Sign(version input.MuSig2Version, privKeys []*btcec.PrivateKey, |
There was a problem hiding this comment.
I wonder if it's worth moving this to say utils package?
There was a problem hiding this comment.
There's a utils.go and a utils/htlc_utils.go. Should we create utils/musig.go. Although sometimes utils is an anti pattern.
There was a problem hiding this comment.
Yeah sgtm, it is somewhat of a too generic name I agree, but at least it is reusable.
There was a problem hiding this comment.
Ideally the server would also use this functionality.
hieblmi
force-pushed
the
static-addr-script
branch
3 times, most recently
from
7827315 to
5931612
Compare
hieblmi
force-pushed
the
static-addr-script
branch
from
5931612 to
249a493
Compare
staticaddr/script/script.go
Outdated
|
|
||
| // TaprootExpiryScriptSize evaluates to 39 bytes: | ||
| // - OP_DATA: 1 byte (trader_key length) | ||
| // - <trader_key>: 32 bytes |
There was a problem hiding this comment.
nit here and in other places: trader key is a relict from loop (that is also found in the reservations scripts cough cough)
There was a problem hiding this comment.
...from pool? Will change it caugh caugh.
| } | ||
|
|
||
| // NewStaticAddress constructs a static address script. | ||
| func NewStaticAddress(muSig2Version input.MuSig2Version, csvExpiry int64, |
There was a problem hiding this comment.
IMO I think it makes sense to pass over *btcec.PublicKey, as a toplevel function should handle the parsing
hieblmi
force-pushed
the
static-addr-script
branch
4 times, most recently
from
958a7b7 to
7c2640d
Compare
In this PR we introduce taproot scripting for static loop-in addresses.