This repository has been archived by the owner on Nov 14, 2017. It is now read-only.
Macho support #43
Merged
Macho support #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention, fixes #29 |
Mostly replaces C99-styled comments with their universally-compliant versions; Tries to reorganize the sections (macro-first, type definition, and class defintion last); and repharses comments to address readablility.
Tried to match comment styles. Added FIXME's to places that might need review later. Conflicts: libs/getExecSections/getExec.cpp
After some querying Markus about a commented function in this module, I decided to remove a commented-out function that wasn't part of the spec.
[ci skip] Conflicts: libs/getExecSections/getExec.cpp
The function didn't quite match what was intended for it. A TargetArch t was passed -- as a value -- and then overwritten inside the code. It was never checked to make any decisions. From discussions spawned in slack, I could figure that we wanted to use t to select one of the available architechtures in the FAT header. Conflicts: libs/getExecSections/getExec.cpp
The older way of doing this was iterating over all executable code, now, we check the ExecCodeProvider's flags to verify that we are actually loading code for the specified architechture Conflicts: libs/getExecSections/getExec.cpp
SantiagoTorres
force-pushed
the
macho-support
branch
2 times, most recently
from
2a78cda to
9672789
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General review of the mach-o loading functions.
I tried to clean the module up a little bit for readability also