fix: get rid of double division on shares to eth conversion #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: 5ee67ae Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
approved these changes
Jan 14, 2025
| .mul(_getTotalShares()) | ||
| .div(_getTotalPooledEther()); | ||
| .mul(_getShareRateDenominator()) // denominator in shares | ||
| .div(_getShareRateNumerator()); // numerator in ether |
There was a problem hiding this comment.
This naming pattern with numerator/denominator is confusing because here _getShareRateNumerator is used as a denominator
There was a problem hiding this comment.
See no real alternative. And, btw, it's still a numerator for share rate here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External shares concept introduce double division during the shares to eth conversion calculations and vise versa.
The suggested way to fix it is to use internal ether and internal shares for conversion in
getPooledEthForShares()andgetSharesForPoooledEther()