New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: develop from core repo #854

Merged

TheDZhon merged 1,110 commits into develop from sync/develop

Oct 11, 2024

Merged

sync: develop from core repo #854

fix: typecheck

GitHub Advanced Security / Slither succeeded Oct 10, 2024 in 5s

1 new alert including 1 medium severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 29 in contracts/0.8.9/lib/SafeCastExt.sol

Code scanning / Slither

Dubious Typecast Medium

Dubious typecast in SafeCastExt.toUint48(uint256):
uint256 => uint48 casting occurs in uint48(value)

Check warning on line 639 in contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol

Code scanning / Slither

Dubious Typecast Medium

Dubious typecast in OracleReportSanityChecker._sumNegativeRebasesNotOlderThan(uint256):
uint256 => int256 casting occurs in index = int256(reportData.length) - 1
int256 => uint256 casting occurs in reportData[uint256(index)].timestamp > SafeCast.toUint64(_timestamp)
int256 => uint256 casting occurs in sum += reportData[uint256(index)].negativeCLRebaseWei

Check warning on line 648 in contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol

Code scanning / Slither

Dubious Typecast Medium

Dubious typecast in OracleReportSanityChecker._exitedValidatorsAtTimestamp(uint256):
uint256 => int256 casting occurs in index = int256(reportData.length) - 1
int256 => uint256 casting occurs in reportData[uint256(index)].timestamp <= SafeCast.toUint64(_timestamp)
int256 => uint256 casting occurs in reportData[uint256(index)].totalExitedValidators

Check warning on line 717 in contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol

Code scanning / Slither

Unused return Medium

OracleReportSanityChecker._askSecondOpinion(uint256,uint256,uint256,LimitsList) ignores return value by (success,clOracleBalanceGwei,oracleWithdrawalVaultBalanceWei,None,None) = secondOpinionOracle.getReport(_refSlot)