Compilation Errors

[0x90shell]

Compiling on Arch I get the following errors related to osdlib:

In file included from ../../../../../src/osd/modules/lib/osdlib_retro.cpp:18:
../../../../../src/osd/modules/lib/osdlib.h: In member function ‘bool osd::virtual_memory_allocation::set_access(std::size_t, std::size_t, unsigned int)’:
../../../../../src/osd/modules/lib/osdlib.h:111:68: error: ‘uint8_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
  111 |                         return do_set_access(reinterpret_cast<std::uint8_t *>(m_memory) + start, size, access);
      |                                                                    ^~~~~~~
      |                                                                    wint_t
../../../../../src/osd/modules/lib/osdlib.h:111:76: error: expected ‘>’ before ‘*’ token
  111 |                         return do_set_access(reinterpret_cast<std::uint8_t *>(m_memory) + start, size, access);
      |                                                                            ^
../../../../../src/osd/modules/lib/osdlib.h:111:76: error: expected ‘(’ before ‘*’ token
../../../../../src/osd/modules/lib/osdlib.h:111:77: error: expected primary-expression before ‘>’ token
  111 |                         return do_set_access(reinterpret_cast<std::uint8_t *>(m_memory) + start, size, access);
      |                                                                             ^
../../../../../src/osd/modules/lib/osdlib.h:111:89: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
  111 |                         return do_set_access(reinterpret_cast<std::uint8_t *>(m_memory) + start, size, access);
      |                                                                              ~~~~~~~~~~~^~~~~~~
make[3]: *** [ocore_retro.make:633: ../../../../libretro/obj/x64/libretro/ocore_retro/src/osd/modules/lib/osdlib_retro.o] Error 1
make[2]: *** [Makefile:19: ocore_retro] Error 2

[0x90shell]

From upstream issue: zach-morris#12 (comment)

It seems the Mame related files and folders need to be updated to more recent releases to ensure compilation on modern dev environments.

@LibretroAdmin

[2play]

@0x90shell
replace /src/osd/modules/lib/osdlib.h with attached (remove from name the .txt)

osdlib.h.txt

run your compile again

[2play]

@0x90shell
if of interest:

• Tested current git source on RockPro64 Armbian Ubuntu 20.04 (compiles ok without new osdlib.h)

• Tested current git source on Pi5 Armbian Ubuntu 24.04 (fails without updated osdlib.h)

• Tested current git source on Pi5 Armbian Ubuntu 24.04 (compiles ok with updated osdlib.h)