Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fonttools against TTF files to save 300KB~ #473

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

C0rn3j
Copy link
Contributor

@C0rn3j C0rn3j commented Apr 1, 2024

Conversation in #471

This needs testing before merge.

Copy link
Collaborator

@baxysquare baxysquare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR, as it will reduce the font sized in the repository. But I don't currently have an environment to test it in. We could really use some help from @LibretroAdmin or another top contributor to the main project.

Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work on Linux with XMB. I don't have any other devices to really test this on, but I assume it's okay?

Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a conflict since your last commit?

@C0rn3j C0rn3j closed this Jun 3, 2024
@C0rn3j C0rn3j force-pushed the optimize-images-p2 branch from c1c2df2 to 771e60b Compare June 3, 2024 14:05
@C0rn3j C0rn3j reopened this Jun 3, 2024
@C0rn3j
Copy link
Contributor Author

C0rn3j commented Jun 3, 2024

Had to hard reset the fork, but it shouldn't conflict anymore.

@fpscan fpscan requested a review from RobLoach June 3, 2024 18:55
@LibretroAdmin
Copy link
Contributor

We'll try this. If it causes issues we will have to revert it.

@LibretroAdmin LibretroAdmin merged commit 52baf3c into libretro:master Dec 30, 2024
@C0rn3j C0rn3j deleted the optimize-images-p2 branch December 30, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants