Skip to content

Commit ce7de34

Browse files
authored
lutro: fix a whoooole bunch of prototype warnings (#264)
An interesting trivia of C99/C11 is that it isn't supposed to allow `()` for void functions. This is due to a classic rule of C language where `()` was actually a type of varadic, and matches any number of arguments. Thus, the use of either `(void)` or `(...)` is recommended for C programs to clearly differentiate them from the ambiguous `()` definition. (this doesn't apply to C++ code)
1 parent c5a6362 commit ce7de34

21 files changed

+33
-33
lines changed

audio.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ void lutro_audio_init(lua_State* L)
274274
lua_setglobal(L, "refs_audio_playing");
275275
}
276276

277-
void lutro_audio_deinit()
277+
void lutro_audio_deinit(void)
278278
{
279279
if (!sources_playing) return;
280280

audio.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ typedef struct
3636
} audio_Source;
3737

3838
void lutro_audio_init(lua_State* L);
39-
void lutro_audio_deinit();
39+
void lutro_audio_deinit(void);
4040
void lutro_audio_stop_all(lua_State* L);
4141
int lutro_audio_preload(lua_State *L);
4242
void lutro_mixer_render(int16_t* buffer);

event.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ int lutro_event_preload(lua_State *L)
1818
return 1;
1919
}
2020

21-
void lutro_event_init()
21+
void lutro_event_init(void)
2222
{
2323
}
2424

filesystem.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,14 @@ int lutro_filesystem_preload(lua_State *L)
108108
return 1;
109109
}
110110

111-
void lutro_filesystem_init()
111+
void lutro_filesystem_init(void)
112112
{
113113
#if WANT_PHYSFS
114114
PHYSFS_init(NULL);
115115
#endif
116116
}
117117

118-
void lutro_filesystem_deinit()
118+
void lutro_filesystem_deinit(void)
119119
{
120120
#if WANT_PHYSFS
121121
PHYSFS_deinit();

filesystem.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
#include <stdbool.h>
88
#include "runtime.h"
99

10-
void lutro_filesystem_init();
11-
void lutro_filesystem_deinit();
10+
void lutro_filesystem_init(void);
11+
void lutro_filesystem_deinit(void);
1212
int lutro_filesystem_preload(lua_State *L);
1313

1414
int fs_read(lua_State *L);

image.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ int lutro_image_preload(lua_State *L)
2929
return 1;
3030
}
3131

32-
void lutro_image_init()
32+
void lutro_image_init(void)
3333
{
3434
}
3535

image.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#define BLUE_MASK 0x000000FF
3030
#endif
3131

32-
void lutro_image_init();
32+
void lutro_image_init(void);
3333
int lutro_image_preload(lua_State *L);
3434

3535
void *image_data_create_from_path(lua_State *L, const char *path);

lutro.c

+6-6
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ void lutro_newlib_x(lua_State* L, luaL_Reg const* funcs, char const* fieldname,
236236
lua_pop(L, 1);
237237
}
238238

239-
void lutro_init()
239+
void lutro_init(void)
240240
{
241241
L = luaL_newstate();
242242

@@ -316,7 +316,7 @@ void lutro_init()
316316
player_checked_stack_end(L, 0);
317317
}
318318

319-
void lutro_deinit()
319+
void lutro_deinit(void)
320320
{
321321
#ifdef HAVE_INOTIFY
322322
if (settings.live_enable)
@@ -661,7 +661,7 @@ void lutro_run(double delta)
661661
lua_gc(L, LUA_GCSTEP, 0);
662662
}
663663

664-
void lutro_reset()
664+
void lutro_reset(void)
665665
{
666666
player_checked_stack_begin(L);
667667
luax_reqglobal(L, "lutro");
@@ -680,7 +680,7 @@ void lutro_reset()
680680
lua_gc(L, LUA_GCSTEP, 0);
681681
}
682682

683-
size_t lutro_serialize_size()
683+
size_t lutro_serialize_size(void)
684684
{
685685
size_t size = 0;
686686

@@ -779,7 +779,7 @@ void lutro_cheat_set(unsigned index, bool enabled, const char *code)
779779
lua_gc(L, LUA_GCSTEP, 0);
780780
}
781781

782-
void lutro_cheat_reset()
782+
void lutro_cheat_reset(void)
783783
{
784784
player_checked_stack_begin(L);
785785
luax_reqglobal(L, "lutro");
@@ -878,7 +878,7 @@ void *lutro_realloc_internal(void *ptr, size_t size, const char* debug, int line
878878
return a;
879879
}
880880

881-
void lutro_print_allocation() {
881+
void lutro_print_allocation(void) {
882882
#if TRACE_ALLOCATION
883883
fprintf(stderr,"TRACE ALLOC:total pending allocations:%d\n", allocation_count);
884884
#endif

lutro.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ typedef struct lutro_settings_t {
3737
extern lutro_settings_t settings;
3838
extern struct retro_perf_callback perf_cb;
3939

40-
void lutro_init();
41-
void lutro_deinit();
40+
void lutro_init(void);
41+
void lutro_deinit(void);
4242

4343
int lutro_load(const char *path);
4444
void lutro_run(double delta);
45-
void lutro_reset();
46-
size_t lutro_serialize_size();
45+
void lutro_reset(void);
46+
size_t lutro_serialize_size(void);
4747
bool lutro_serialize(void *data_, size_t size);
4848
bool lutro_unserialize(const void *data_, size_t size);
49-
void lutro_cheat_reset();
49+
void lutro_cheat_reset(void);
5050
void lutro_cheat_set(unsigned index, bool enabled, const char *code);
5151

5252
void lutro_shutdown_game(void);
@@ -68,7 +68,7 @@ void *lutro_malloc_internal(size_t size, const char* debug, int line);
6868
void *lutro_calloc_internal(size_t nmemb, size_t size, const char* debug, int line);
6969
void *lutro_realloc_internal(void *ptr, size_t size, const char* debug, int line);
7070
void lutro_free_internal(void *ptr, const char* debug, int line);
71-
void lutro_print_allocation();
71+
void lutro_print_allocation(void);
7272
#define lutro_malloc(size) lutro_malloc_internal(size, __FILE__, __LINE__)
7373
#define lutro_calloc(nmemb, size) lutro_calloc_internal(nmemb, size, __FILE__, __LINE__)
7474
#define lutro_realloc(ptr, size) lutro_realloc_internal(ptr, size, __FILE__, __LINE__)

lutro_math.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include <string.h>
66
#include <time.h>
77

8-
void lutro_math_init()
8+
void lutro_math_init(void)
99
{
1010
time_t t;
1111
srand((unsigned) time(&t));

lutro_math.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <stdbool.h>
88
#include "runtime.h"
99

10-
void lutro_math_init();
10+
void lutro_math_init(void);
1111
int lutro_math_preload(lua_State *L);
1212
int lutro_math_random(lua_State *L);
1313
int lutro_math_setRandomSeed(lua_State *L);

lutro_window.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ int lutro_window_preload(lua_State *L)
3333
return 1;
3434
}
3535

36-
void lutro_window_init()
36+
void lutro_window_init(void)
3737
{
3838
}
3939

lutro_window.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <stdbool.h>
88
#include "runtime.h"
99

10-
void lutro_window_init();
10+
void lutro_window_init(void);
1111
int lutro_window_preload(lua_State *L);
1212

1313
int win_close(lua_State *L);

mouse.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ int lutro_mouse_preload(lua_State *L)
2323
return 1;
2424
}
2525

26-
void lutro_mouse_init()
26+
void lutro_mouse_init(void)
2727
{
2828
}
2929

mouse.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include "runtime.h"
77

88
int lutro_mouse_preload(lua_State *L);
9-
void lutro_mouse_init();
9+
void lutro_mouse_init(void);
1010
void lutro_mouseevent(lua_State* L);
1111
int mouse_isDown(lua_State *L);
1212
int mouse_getX(lua_State *L);

sound.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ int lutro_sound_preload(lua_State *L)
1919
return 1;
2020
}
2121

22-
void lutro_sound_init()
22+
void lutro_sound_init(void)
2323
{
2424
}
2525

sound.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ typedef struct
2020
mixer_presaturate_t* data;
2121
} snd_SoundData;
2222

23-
void lutro_sound_init();
23+
void lutro_sound_init(void);
2424
int lutro_sound_preload(lua_State *L);
2525

2626
int snd_newSoundData(lua_State *L);

system.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ int lutro_system_preload(lua_State *L)
2727
return 1;
2828
}
2929

30-
void lutro_system_init()
30+
void lutro_system_init(void)
3131
{
3232
}
3333

system.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <stdbool.h>
88
#include "runtime.h"
99

10-
void lutro_system_init();
10+
void lutro_system_init(void);
1111
int lutro_system_preload(lua_State *L);
1212

1313
int sys_getOS(lua_State *L);

timer.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ int lutro_timer_preload(lua_State *L)
1818
return 1;
1919
}
2020

21-
void lutro_timer_init()
21+
void lutro_timer_init(void)
2222
{
2323
}
2424

timer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <stdbool.h>
88
#include "runtime.h"
99

10-
void lutro_timer_init();
10+
void lutro_timer_init(void);
1111
int lutro_timer_preload(lua_State *L);
1212

1313
int timer_getTime(lua_State *L);

0 commit comments

Comments
 (0)