Save SRAM and state on Android shutdown #17577
Conversation
location/drivers/android.c
Outdated
| /* Flush SRAM to disk */ | ||
| command_event(CMD_EVENT_SAVE_FILES, NULL); | ||
|
|
||
| /* TODO: Save config? */ |
There was a problem hiding this comment.
As hinted at by the original PR, there's this UWP function that seems to save the config:
Line 515 in 73bc409
I'm not sure if these two functions are supposed to be functionally equivalent.
| androidlocation_t *androidlocation = (androidlocation_t*)data; | ||
| JNIEnv *env = jni_thread_getenv(); | ||
| if (!env) | ||
| if (!androidlocation || !env) |
There was a problem hiding this comment.
Not sure why the original PR added this check. If androidlocation is nullptr, handling it like this is probably wrong.
Thoughts?
There was a problem hiding this comment.
🤷 Probably in case the app was told to stop multiple times, to avoid multiple unnecessary writes? Not sure it really matters, the calls are supposed to be smart enough to know that nothing needs to be written.
|
The original PR replicated the code changes in the header (!) inside AFAICT, |
| return; | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
Looking at the iOS version: https://github.com/libretro/RetroArch/blob/master/ui/drivers/ui_cocoatouch.m#L793
We can see that the only event called is CMD_EVENT_SAVE_FILES. I commented out this code block for now but left the code until I gain more clarity from the discussion in other threads.
There was a problem hiding this comment.
iOS is probably wrong here.
Guidelines
Description
Bring relevant changes in #14804 forward to latest upstream.
Related Issues
#14518
Reviewers
@hizzlekizzle
@warmenhoven