Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add to playlist dialog #7074

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Pittvandewitt
Copy link
Contributor

This PR does several things to improve the code quality:

  • Perform Database and Network requests in the ViewModel to make it survive configuration changes
  • IO work is ensured to be performed in the IO dispatcher by defining it at function level
  • Playlists are only fetched once
  • AddToPlaylistDialog UI state now survives process death

…efactor/add-to-playlist

# Conflicts:
#	app/src/main/java/com/github/libretube/ui/dialogs/AddToPlaylistDialog.kt
#	app/src/main/java/com/github/libretube/ui/models/PlaylistViewModel.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants