-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StreamsExtractor): generate PoToken #7069
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as spam.
This comment was marked as spam.
Please don't add unnecessary comments. Linking an issue to be closed is fine, but the rest just adds noise. I'm already well aware of the NewPipe PR (see description above). |
Sorry.
|
The crash log is a temporary DNS issue on your side, that's not LibreTube related. |
3a637c3
to
98a0bf1
Compare
A source error still occurs when starting a video in HLS.XRecorder_20250205_01.mp4 |
Implements support for locally generating PoTokens using the device webview. This is a direct port of TeamNewPipe/NewPipe#11955 to native Kotlin. Closes: libre-tube#7065
c0c210f
to
817521a
Compare
A few questions:
|
This issues seem to be NewPipeExtractor bug itself, since HLS don't need
Uhm u should port it also |
With the current code the purpose of I suggest to do one of these to make it more obvious it is about po tokens:
NewPipe did the first option here and put everything po token related into a sub package: |
Implements support for locally generating PoTokens using the device web view. This is a direct port of
TeamNewPipe/NewPipe#11955 to native Kotlin.
However, there are some notable differences:
PoTokenGenerator
interface. As there is only one implementation right now, this is skippedminSdk
in BREAKING CHANGE: bump minSdk to 26 #7047, I'm hoping we can get away withoutIt is marked as a draft, since while it does generate valid PoTokens, playback does not work (Source error: open failed: ENOENT
; help is appreciated).Closes: #7065