Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: bump minSdk to 26 #7047

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

Pittvandewitt
Copy link
Contributor

Based on #7039 and #6986 I took the freedom to bump the minSdk to 26

@Pittvandewitt Pittvandewitt marked this pull request as ready for review February 5, 2025 16:47
@Bnyro Bnyro changed the title Bump minSdk to 26 BREAKING CHANGE: bump minSdk to 26 Feb 5, 2025
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bnyro Bnyro merged commit 7266455 into libre-tube:master Feb 5, 2025
2 of 3 checks passed
@Bnyro
Copy link
Member

Bnyro commented Feb 5, 2025

Okay, I just noticed that after this PR, the language in the main activity can no longer be changed (settings -> language), it only appears to be different in all other activities.

So we might need to re-add updateResourcesLegacy for now, even though that's probably not the right solution to prevent that bug.

@Bnyro
Copy link
Member

Bnyro commented Feb 5, 2025

Fixed with #7078, the previous code for updating the resources was just completely wrong because it created a new configuration context that wasn't actually attached to the activity ...

@Pittvandewitt Pittvandewitt deleted the feat/bump-minsdk branch February 5, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants