Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macros): handle negative discriminants #188

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

6d7a
Copy link
Member

@6d7a 6d7a commented Oct 27, 2023

Implementing JER-support, I noticed that negative enum discriminators are not handled correctly in macros. This PR fixes that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@6d7a 6d7a mentioned this pull request Oct 27, 2023
@Nicceboy Nicceboy mentioned this pull request Oct 29, 2023
@XAMPPRocky
Copy link
Collaborator

Looks good, but the CI isn't passing

@6d7a
Copy link
Member Author

6d7a commented Nov 7, 2023

@XAMPPRocky I see that the CI checks have passed. Could we merge this?

@XAMPPRocky
Copy link
Collaborator

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 4c61085 into librasn:main Nov 7, 2023
@6d7a 6d7a deleted the fix/enum-discriminators branch November 20, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants