Merge pull request #888 from fxfactorial/leak

[discovery] missing defer .Stop on ticker
libp2p · Apr 17, 2020 · 76b080c · 76b080c
2 parents 6f4961b + 28f45ac
commit 76b080c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/p2p/discovery/mdns.go b/p2p/discovery/mdns.go
@@ -119,8 +119,9 @@ func (m *mdnsService) Close() error {
 }
 
 func (m *mdnsService) pollForEntries(ctx context.Context) {
-
 	ticker := time.NewTicker(m.interval)
+	defer ticker.Stop()
+
 	for {
 		//execute mdns query right away at method call and then with every tick
 		entriesCh := make(chan *mdns.ServiceEntry, 16)