From 01e7200312219f3f2ccb9f21fc9def69e5f48f60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20M=C3=BCller?= Date: Thu, 6 Feb 2025 11:20:41 -0800 Subject: [PATCH] Use maps::parse_filtered() for process symbolization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In general not all entries in /proc/[pid]/maps are of interest to us and we perform some pre-filtering based on somewhat coarse grained criteria. However, for one reason or another we didn't do that in the symbolization logic, only when normalizing. Having failed to surface why that is, exactly, let's switch over to using the filtered version nonetheless, as none of our tests fail with the filtered version. Do so should speed up things a bit and make follow-on changes easier to digest. Signed-off-by: Daniel Müller --- src/symbolize/symbolizer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/symbolize/symbolizer.rs b/src/symbolize/symbolizer.rs index 1d8f3849b..87a9bde83 100644 --- a/src/symbolize/symbolizer.rs +++ b/src/symbolize/symbolizer.rs @@ -898,7 +898,7 @@ impl Symbolizer { perf_map: bool, map_files: bool, ) -> Result> { - let mut entry_iter = maps::parse(pid)?; + let mut entry_iter = maps::parse_filtered(pid)?; let entries = |_addr| entry_iter.next(); let mut handler = SymbolizeHandler {