Use maps::parse_filtered() for process symbolization #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general not all entries in /proc/[pid]/maps are of interest to us and we perform some pre-filtering based on somewhat coarse grained criteria. However, for one reason or another we didn't do that in the symbolization logic, only when normalizing. Having failed to surface why that is, exactly, let's switch over to using the filtered version nonetheless, as none of our tests fail with the filtered version. Do so should speed up things a bit and make follow-on changes easier to digest. Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 58 58
Lines 10750 10750
=======================================
Hits 10211 10211
Misses 539 539 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general not all entries in
/proc/[pid]/mapsare of interest to us and we perform some pre-filtering based on somewhat coarse grained criteria. However, for one reason or another we didn't do that in the symbolization logic, only when normalizing. Having failed to surface why that is, exactly, let's switch over to using the filtered version nonetheless, as none of our tests fail with the filtered version. Do so should speed up things a bit and make follow-on changes easier to digest.