Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "runs-on" value in CI matrix cache key #455

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Include "runs-on" value in CI matrix cache key #455

merged 1 commit into from
Dec 19, 2023

Conversation

danielocfb
Copy link
Collaborator

It doesn't really make sense to restore, say, Linux build artifacts for a MacOS build.
Include the "runs-on" value in the cache key we use for the matrix to make that happening less likely.

It doesn't really make sense to restore, say, Linux build artifacts for
a MacOS build.
Include the "runs-on" value in the cache key we use for the matrix to
make that happening less likely.

Signed-off-by: Daniel Müller <deso@posteo.net>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (519d7fe) 92.32% compared to head (c58ca61) 92.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files          41       41           
  Lines        6397     6397           
=======================================
  Hits         5906     5906           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielocfb danielocfb merged commit 0f68e4c into libbpf:main Dec 19, 2023
29 checks passed
@danielocfb danielocfb deleted the topic/runs-on-cache-key branch December 19, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants