Improve handling of dynamic ELF symbols #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can be overlap between dynamic and static symbols. For us that means that when iterating over all symbols we would see duplicates being reported. On top of that, we waste memory by having the same information available in two arrays. With this change we make sure to filter out any dynamic symbols that are already present as static symbols to fix both issues. Signed-off-by: Daniel Müller <deso@posteo.net>
This change introduces the SymbolTableCache type, as a helper for working with symbol tables. In the future this type will allow us to more easily add proper support for dynamic symbol lookup. Signed-off-by: Daniel Müller <deso@posteo.net>
With the introduction and usage of OnceCell a while back, we can simplify the ElfParser::for_each_sym() method by using straight iteration. Signed-off-by: Daniel Müller <deso@posteo.net>
Since basically its inception (85b0f16), support for dynamic symbols in any shape or form has been flawed: we only considered dynamic symbols as a fallback if no static (?) symbols are present. However, it is entirely possible to have exclusive dynamic symbols in use, which would be ignored entirely. This change fixes this shortcoming, by considering both tables when looking up symbols from address or by name. Signed-off-by: Daniel Müller <deso@posteo.net>
This change adds a test for the lookup of a dynamic symbol by name as well as by address. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
force-pushed
the
topic/dynsyms
branch
2 times, most recently
from
c9a2b9e to
65d6e65
Compare
Merged
|
Superseded by #472. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.