Introduce Reason enumeration to accompany Symbolized::Unknown variant
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adjusts the internally used Handler trait with an additional generic argument that can be used for providing additional data to the Handler::handle_unknown_addr() method call. The ability to provide this data will be necessary with upcoming changes. Signed-off-by: Daniel Müller <deso@posteo.net>
Many paths can lead to an unsuccessful symbolization, and it may be hard for callers to figure out why symbolization didn't pan out. For example, a user may have provided a stripped binary, without being aware of that fact. With this change we introduce the symbolize::Reason enumeration, which now accompanies the Symbolized::Unknown variant and aims to provide a best guess as to why symbolization was not successful. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
force-pushed
the
topic/unknown-reason
branch
from
a049e1f to
628fdb0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 92.26% 92.30% +0.04%
==========================================
Files 41 41
Lines 6347 6397 +50
==========================================
+ Hits 5856 5905 +49
- Misses 491 492 +1 ☔ View full report in Codecov by Sentry. |
d-e-s-o
force-pushed
the
topic/unknown-reason
branch
from
628fdb0 to
e7d9eb4
Compare
d-e-s-o
changed the title
Symbolized::Unknown variant
|
Should be ready for review now. |
anakryiko
approved these changes
Dec 15, 2023
This change adds a test attempting symbolization on a stripped binary. The test makes sure that the reason we report for the unsuccessful symbolization is the fact that symbols are missing. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
force-pushed
the
topic/unknown-reason
branch
from
e7d9eb4 to
4c30ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many paths can lead to an unsuccessful symbolization, and it may be hard for callers to figure out why symbolization didn't pan out. For example, a user may have provided a stripped binary, without being aware of that fact.
With this change we introduce the symbolize::Reason enumeration, which now accompanies the Symbolized::Unknown variant and aims to provide a best guess as to why symbolization was not successful.