Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide-previous-comment now can handel matrix strategy runs when given a unique comment-header #78

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

jburns24
Copy link
Contributor

No description provided.

Copy link

Terraform Plan Changes

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Terraform Plan Changes

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Terraform Plan Changes

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

This comment has been minimized.

Copy link

BIG HEADER

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh
BIG FOOTER

Workflow: Action Tester Workflow

Copy link

There were no changes done to the infrastructure.

Copy link

Terraform Plan Changes

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Terraform Plan Changes

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Terraform Plan Changes

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

This comment has been minimized.

Copy link

BIG HEADER

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh
BIG FOOTER

Workflow: Action Tester Workflow

Copy link

There were no changes done to the infrastructure.

@jburns24 jburns24 changed the title Matrix support fix: hide-previous-comment now can handel matrix strategy runs when given a unique comment-header Dec 11, 2024
$ ncc build index.js --out dist --license licenses.txt
ncc: Version 0.33.4
ncc: Compiling file index.js into CJS
 36kB  dist/licenses.txt
900kB  dist/index.js
936kB  [744ms] - ncc 0.33.4
Done in 1.00s.
Copy link

Terraform Plan Changes

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Terraform Plan Changes

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Terraform Plan Changes

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

This comment has been minimized.

Copy link

BIG HEADER

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh
BIG FOOTER

Workflow: Action Tester Workflow

Copy link

There were no changes done to the infrastructure.

Copy link

Terraform Plan Changes

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Terraform Plan Changes

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Terraform Plan Changes

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

Copy link

Same as previous but previous comment should be hidden.

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Same as previous but previous comment should be hidden.

Terraform Plan: 9 to be created, 1 to be deleted, 1 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh

Resources to delete

- azurerm_network_interface.calvin-nic

Resources to update

! azurerm_network_interface_security_group_association.calvin-sg-nic

Same as previous but previous comment should be hidden.

Terraform Plan: 1 to be created, 0 to be deleted, 1 to be updated, 1 to be replaced, 35 unchanged.

Resources to create

+ module.aks_lz.module.key_vault.azurerm_private_endpoint.key_vault

Resources to update

! module.aks_lz.module.key_vault.azurerm_key_vault.key_vault

Resources to replace

- module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]
+ module.aks_lz.azurerm_virtual_hub_connection.aks_vnet_hub_connection[0]

Copy link

BIG HEADER

Terraform Plan: 11 to be created, 0 to be deleted, 0 to be updated, 0 to be replaced, 0 unchanged.

Resources to create

+ azurerm_linux_virtual_machine.calvinvm
+ azurerm_network_interface.calvin-nic
+ azurerm_network_interface_security_group_association.calvin-sg-nic
+ azurerm_network_security_group.calvin-security-group
+ azurerm_public_ip.calvin-ip
+ azurerm_resource_group.calvin
+ azurerm_storage_account.calvin-sa
+ azurerm_subnet.calvin-subnet
+ azurerm_virtual_network.calvin-vn
+ random_id.calvin-rid
+ tls_private_key.calvin_ssh
BIG FOOTER

Workflow: Action Tester Workflow

Copy link

There were no changes done to the infrastructure.

@jburns24 jburns24 merged commit 95ca081 into main Dec 12, 2024
4 checks passed
@jburns24 jburns24 deleted the matrixSupport branch December 12, 2024 20:13
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
## [1.7.1](v1.7.0...v1.7.1) (2024-12-12)

### Bug Fixes

* `hide-previous-comment` now can handel matrix strategy runs when given a unique `comment-header` ([#78](#78)) ([95ca081](95ca081))
Copy link

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants