Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow sidebar width adjustment & cleanup toggle logic #806

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

NoritakaIkeda
Copy link
Member

@NoritakaIkeda NoritakaIkeda commented Mar 4, 2025

Issue

Why is this change needed?

This PR introduces improvements to the sidebar functionality, including width adjustment, persistent storage, and hover effects. It also cleans up redundant code and resolves a sidebar state inconsistency issue.

What would you like reviewers to focus on?

  • Ensuring smooth sidebar width adjustment
  • Verifying that hover effects behave as expected
  • Checking for any regressions caused by the cleanup of redundant sidebar logic
  • Validating that the sidebar state is now correctly maintained

Testing Verification

2025-03-04.21.54.16.mov

Concerns

  1. SSR-Related Issue with shadcn/ui Resizable Component

    • The newly introduced Resizable component from shadcn/ui seems to cause issues related to server-side rendering.
    • Specifically, an error related to react-dev-overlay appears on the screen but is not visible in the console logs.
      Missing Sidebar Animation on Toggle
    • スクリーンショット 2025-03-04 22 07 04
  2. Currently, the sidebar does not have an animation when opening or closing.

    • The Resizable component from shadcn/ui does not provide built-in support for such animations, making it challenging to implement smoothly.
  3. Sidebar Opens with minSize After Reload

    • When the sidebar is closed and the page is reloaded, reopening it causes it to appear at the minSize width instead of the last stored width.
    • This behavior is inconsistent and might need additional logic to ensure the correct width is restored.
2025-03-04.22.08.18.mov

What was done

pr_agent:summary

Detailed Changes

pr_agent:walkthrough

Additional Notes

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 762a262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
test-liam-docs ⬜️ Ignored (Inspect) Mar 4, 2025 0:59am
test-liam-erd-sample ⬜️ Ignored (Inspect) Mar 4, 2025 0:59am
test-liam-erd-web ⬜️ Ignored (Inspect) Mar 4, 2025 0:59am

Copy link

vercel bot commented Mar 4, 2025

@NoritakaIkeda is attempting to deploy a commit to the ROUTE06 Core Team on Vercel.

A member of the Team first needs to authorize it.

@NoritakaIkeda NoritakaIkeda self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Sidebar Width Adjustment
1 participant