-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Unify focus ring color with brand theme #635
💄 Unify focus ring color with brand theme #635
Conversation
|
The Vercel deployment doesn't work with PR from fork. I'll fix it later! |
@JonathanDeLaCruzEncora Can you also adjust each button and link in the header? ![]() ![]() |
@JonathanDeLaCruzEncora |
Buttons in header updated, as well as the mobile open/close button and other buttons like the close button in the toolbar which I didn't change previously. All the buttons that had squared outlines now are rounded, including the view/hide button in the side menu (I also added the brand color to its outline) If there are any changes feel free to let me know 😄 |
@JonathanDeLaCruzEncora Oh, sorry, please resolve conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM😄 Thanks for adjusting!
Just resolve the conflicts and we'll merge!
@JonathanDeLaCruzEncora Just correct the format at the end! |
@JonathanDeLaCruzEncora CI is down. |
Head branch was pushed to by a user without write access
7c0669a
to
b6542fc
Compare
@MH4GF Thank you so much for that, it should be fine now, wouldn't have done it without your help |
@JonathanDeLaCruzEncora Thanks for your perseverance! |
Summary
This PR changes the color of all buttons or focusable items, from the default color to the brand color
Related Issue
This changes solve issue #632
Changes
The code below was added to all the elements I was able to focus, 'auto' was recommended, but was still getting the default outline. After changing to 'solid' for the style, the changes were applied
Below are images of all the components that were changed
Buttons from the toolbar were focusable with drawers closed, when clicking on them and then hitting spacebar. So its a rare case, but they are focusable.
The same with mobile tools.