Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript build error in CLI package: format parameter type mismatch #768

Open
1 task done
devin-ai-integration bot opened this issue Feb 25, 2025 · 3 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@devin-ai-integration
Copy link
Contributor

Version Type

  • CLI Version (npm package)

Steps to reproduce

  1. Run pnpm dev --filter @liam-hq/cli
  2. Observe the TypeScript build error in the console output

Expected Behavior

The build should complete successfully without TypeScript errors.

Actual Behavior

The build fails with the following TypeScript error:

@liam-hq/cli:build: │4(!) [plugin typescript] src/cli/erdCommand/buildCommand/index.ts (18:5): @rollup/plugin-typescript TS2345: Argument of type '"schemarb" | "postgres" | "prisma" | "tbls" | undefined' is not a…: │ /Users/mh4gf/ghq/github.com/liam-hq/liam/frontend/packages/cli/src/cli/erdCommand/buildCommand/index.ts:18:5
@liam-hq/cli:build: │ 
@liam-hq/cli:build: │ 18     format,
@liam-hq/cli:build: │        ~~~~~~

Additional Context

The issue is in the function in . The function accepts an optional parameter (), but when it passes this parameter to the function, there's a type mismatch because expects a non-optional parameter.

The type error occurs because the optional parameter (which could be undefined) is being passed to a function that expects a non-optional parameter.

@devin-ai-integration devin-ai-integration bot added the bug Something isn't working label Feb 25, 2025
@MH4GF MH4GF marked this as a duplicate of #769 Feb 25, 2025
@MH4GF
Copy link
Member

MH4GF commented Feb 25, 2025

This issue resulted from #760
@NoritakaIkeda Are you interested in fixing this issue? It's working fine, so we're not in a hurry 👍🏻

@NoritakaIkeda
Copy link
Member

@MH4GF
Thank you for catching this issue!
I'll take a closer look and work on a fix.

@MH4GF
Copy link
Member

MH4GF commented Feb 25, 2025

@NoritakaIkeda Thanks! I have assigned you. Best regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants