[N001] Use a non-TLS client for SMTP on port 25 #5238

tonhuisman · 2025-01-31T21:10:27Z

Resolves #5237

Bugfix:

Even when using port 25 a secure client was started for the mail-server connection. Now when using port 25, or port 2525, a default WiFiClient is used, instead of a secure client.
Close & destroy client also when server-connection (login?/network?) fails.
Documentation updated about the use of ports 25 and 2525 for ESP32 builds with TLS included.

TODO:

src/src/NotifierStructs/N001_data_struct.cpp

[N001] Use a non-TLS client for SMTP on port 25

478da66

TD-er reviewed Jan 31, 2025

View reviewed changes

src/src/NotifierStructs/N001_data_struct.cpp Show resolved Hide resolved

TD-er reviewed Jan 31, 2025

View reviewed changes

src/src/NotifierStructs/N001_data_struct.cpp Outdated Show resolved Hide resolved

tonhuisman added 3 commits January 31, 2025 23:02

[N001] Allso apply to port 2525

db9a08c

[N001] And clean up object after use

93601da

[N001] Documentation update about port 25 and 2525 (ESP32 with TLS)

91d27bd

TD-er reviewed Feb 1, 2025

View reviewed changes

src/src/NotifierStructs/N001_data_struct.cpp Show resolved Hide resolved

TD-er reviewed Feb 1, 2025

View reviewed changes

src/src/NotifierStructs/N001_data_struct.cpp Outdated Show resolved Hide resolved

tonhuisman added 2 commits February 1, 2025 17:36

[N001] Add pointer null-checks, close client also when connection fails

c4f3a53

[N001] Only delect object if created via new

3a07319

TD-er merged commit 45c4d74 into letscontrolit:mega Feb 1, 2025
168 checks passed

tonhuisman deleted the bugfix/N001-use-SMTP-for-port-25 branch February 2, 2025 09:09

Provide feedback