[CDN URL] Update fallback CDN path...

[chromoxdor]

I changed the path to a more generic URL as suggested here: jsdelivr/jsdelivr#18541

[chromoxdor]

Just realized that it was already changed..
Thanks @TD-er !

[chromoxdor]

I somehow not quite awake :)
i thought you changed it in your PR but you didn´t...

[TD-er]

Not sure if it should be only in the Python file.
If built using Arduino IDE, then no Python file is used.

Ton has a PR which allows to specify a user defined URL.

[chromoxdor]

Ton has a PR which allows to specify a user defined URL.

will test that when i am finished testing his WiFi PR.
Did he implement a fallback URL when non is given?

[chromoxdor]

Or better asked, where is it directing to when pygit2 is missing? As far as is could see this is not part of his PR...
or is it intended to be the part where i enter afterwards my own fallback URL?

[tonhuisman]

Currently it would use this fallback implemented in CompiletimeDefines.cpp if pygit2 is not available (AFAICS) or Arduino IDE compilation is used.

[chromoxdor]

ahh.. i see, thanks.

// FIXME TD-er: Not sure which is better, serving the latest (which will have caching issues) or a tag which will become outdated

I vote for latest. :) (When i freshly make a build i expect to have the latest files)

[TD-er]

ahh.. i see, thanks.

// FIXME TD-er: Not sure which is better, serving the latest (which will have caching issues) or a tag which will become outdated

I vote for latest. :) (When i freshly make a build i expect to have the latest files)

Yep, but the 'latest' will be whatever your browser has in its cache.
So your expectation will probably not match with what you get.

[chromoxdor]

Yep, but the 'latest' will be whatever your browser has in its cache.
So your expectation will probably not match with what you get.

But to fix this i only have to do a hard refresh of the site. The other option would force me worst case to upload a new adjusted firmware.