Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM and Windows vanilla Python to CI runs #609

Merged
merged 12 commits into from
Jan 18, 2025
10 changes: 7 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@ jobs:
- py313
platform:
- ubuntu-latest
- ubuntu-24.04-arm
- macos-latest
- windows-latest
exclude:
- python: py313
platform: windows-latest
steps:
- name: "🛒 Checkout"
uses: actions/checkout@v4
Expand Down Expand Up @@ -91,10 +89,16 @@ jobs:
- '3.13'
platform:
- ubuntu-latest
- ubuntu-24.04-arm
- macos-latest
- windows-latest
exclude:
- python: '3.13'
platform: macos-latest
- python: '3.13'
platform: windows-latest
- python: '3.13'
platform: ubuntu-24.04-arm
steps:
- name: "🛒 Checkout"
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion lenskit/lenskit/logging/monitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
addr = f"ipc://{path}"
sock.bind(addr)
else:
port = sock.bind_to_random_port("127.0.0.1")
port = sock.bind_to_random_port("tcp://127.0.0.1")

Check warning on line 149 in lenskit/lenskit/logging/monitor.py

View check run for this annotation

Codecov / codecov/patch

lenskit/lenskit/logging/monitor.py#L149

Added line #L149 was not covered by tests
addr = f"tcp://127.0.0.1:{port}"
log = _log.bind(address=addr)
log.debug("bound listener socket")
Expand Down
Loading
Loading