Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate PipelineBuilder from Pipeline and update run api #606

Merged
merged 37 commits into from
Jan 16, 2025

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Jan 16, 2025

This makes several significant changes to the pipeline API:

  • PipelineBuilder and Pipeline are now separate, and Pipeline is intended to be immutable.
  • The run method is now takes a tuple instead of varargs, so that its return type can be more obvious.
  • Config hashes are now properties.
  • Default input connections are resolved at build time, not run time (and are no longer included in configurations).

Closes #604.

@mdekstrand mdekstrand added enhancement pipeline LensKit pipeline abstraction labels Jan 16, 2025
@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 95.97315% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.04%. Comparing base (07f70c3) to head (6eab439).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/pipeline/builder.py 96.44% 9 Missing ⚠️
lenskit/lenskit/pipeline/_impl.py 94.36% 4 Missing ⚠️
lenskit/lenskit/pipeline/components.py 95.00% 2 Missing ⚠️
lenskit/lenskit/pipeline/config.py 89.47% 2 Missing ⚠️
lenskit/lenskit/pipeline/nodes.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   89.98%   90.04%   +0.06%     
==========================================
  Files         107      108       +1     
  Lines        6617     6790     +173     
==========================================
+ Hits         5954     6114     +160     
- Misses        663      676      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 33c5ec1 into lenskit:main Jan 16, 2025
37 checks passed
@mdekstrand mdekstrand deleted the feature/pipeline-builder branch January 16, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline LensKit pipeline abstraction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Separate PipelineBuilder from Pipeline
1 participant