Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component configuration type warnings #603

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

mdekstrand
Copy link
Member

This updates the component configuration check logic to use get_type_hints for simplicity + Python-provided correctness, makes Component properly an abstract base class, and improves the configuration type warning logic.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.98%. Comparing base (f5a0422) to head (90eba72).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/pipeline/components.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   89.98%   89.98%   -0.01%     
==========================================
  Files         107      107              
  Lines        6608     6617       +9     
==========================================
+ Hits         5946     5954       +8     
- Misses        662      663       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 07f70c3 into main Jan 14, 2025
39 checks passed
@mdekstrand mdekstrand deleted the tweak/component-config-type-hint branch January 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant