Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pydantic models for component configurations #596

Merged
merged 50 commits into from
Jan 11, 2025

Conversation

mdekstrand
Copy link
Member

This changes the component configuration mechanism to use Pydantic models (or Python dataclasses) instead of ad-hoc constructor parameters, fields, etc.

@mdekstrand mdekstrand added the pipeline LensKit pipeline abstraction label Jan 9, 2025
@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 9, 2025
@mdekstrand mdekstrand self-assigned this Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 97.47191% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (f077dc7) to head (c6186d9).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/pipeline/components.py 91.30% 4 Missing ⚠️
lenskit/lenskit/als/_common.py 96.15% 2 Missing ⚠️
lenskit-implicit/lenskit/implicit.py 94.44% 1 Missing ⚠️
lenskit/lenskit/basic/bias.py 96.15% 1 Missing ⚠️
lenskit/lenskit/basic/popularity.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   90.77%   89.96%   -0.81%     
==========================================
  Files         107      106       -1     
  Lines        6567     6568       +1     
==========================================
- Hits         5961     5909      -52     
- Misses        606      659      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit d1afbcb into lenskit:main Jan 11, 2025
38 of 39 checks passed
@mdekstrand mdekstrand deleted the feature/pydantic-config branch January 11, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline LensKit pipeline abstraction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant