Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Binpickle from tests and docs #423

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

mdekstrand
Copy link
Member

This removes Binpickle from the tests and documentation, as it doesn't work well with Torch at this point. Closes #422.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (19f933e) to head (7f63eb0).
Report is 593 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          45       45           
  Lines        3077     3077           
=======================================
  Hits         2799     2799           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 7f63eb0 into lenskit:main Jun 7, 2024
26 checks passed
@mdekstrand mdekstrand deleted the tweak/422-yeet-binpickle branch June 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Binpickle
1 participant