Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSR from LensKit deps #421

Merged
merged 27 commits into from
Jun 7, 2024

Conversation

mdekstrand
Copy link
Member

This removes usage of the CSR package from LensKit, refactoring the sparse_ratings method to have a clearer API (closes #379).

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Jun 6, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Jun 6, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (cbfe956) to head (19f933e).
Report is 620 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/data/matrix.py 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   90.11%   90.96%   +0.84%     
==========================================
  Files          49       45       -4     
  Lines        3258     3077     -181     
==========================================
- Hits         2936     2799     -137     
+ Misses        322      278      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 19f933e into lenskit:main Jun 7, 2024
26 checks passed
@mdekstrand mdekstrand deleted the feature/379-drop-csr branch June 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace CSR with SciPy or PyTorch sparse arrays
1 participant