Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Popular recommender #420

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

mdekstrand
Copy link
Member

This removes the Popular recommender in favor of PopScore.

@mdekstrand mdekstrand added the components LensKit recommendation components label Jun 6, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Jun 6, 2024
@mdekstrand mdekstrand marked this pull request as ready for review June 6, 2024 20:41
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (cbfe956) to head (d09db54).
Report is 620 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   90.11%   90.13%   +0.01%     
==========================================
  Files          49       49              
  Lines        3258     3233      -25     
==========================================
- Hits         2936     2914      -22     
+ Misses        322      319       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit d09db54 into lenskit:main Jun 6, 2024
26 checks passed
@mdekstrand mdekstrand deleted the tweak/drop-pop branch June 6, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components LensKit recommendation components
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant