try to fix pr

lenskit · Jul 2, 2024 · f121573 · f121573
1 parent 79044d0
commit f121573
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,14 +20,19 @@ jobs:
           fetch-depth: 0
       - id: check-for-changes
         run: |
-          gh pr diff --name-only |grep '^lenskit.*\.py$'
-          if [ "$?" -eq 0 ]; then
+          if [[ -z "$PR_NUMBER" ]]; then
               echo changed=true >>$GITHUB_OUTPUT
           else
-              echo changed=false >>$GITHUB_OUTPUT
+              gh pr diff $PR_NUMBER --name-only |grep '^lenskit.*\.py$'
+              if [ "$?" -eq 0 ]; then
+                  echo changed=true >>$GITHUB_OUTPUT
+              else
+                  echo changed=false >>$GITHUB_OUTPUT
+              fi
           fi
         env:
           GH_TOKEN: ${{ github.token }}
+          PR_NUMBER: ${{ github.event.number }}
   conda:
     name: Conda Python ${{matrix.python}} on ${{matrix.platform}}
     runs-on: ${{matrix.platform}}

diff --git a/lkdev/workflows/test.py b/lkdev/workflows/test.py
@@ -370,14 +370,21 @@ def job_check_changes() -> GHJob:
             {
                 "id": "check-for-changes",
                 "run": script("""
-                    gh pr diff --name-only |grep '^lenskit.*\\.py$'
-                    if [ "$?" -eq 0 ]; then
+                    if [[ -z "$PR_NUMBER" ]]; then
                         echo changed=true >>$GITHUB_OUTPUT
                     else
-                        echo changed=false >>$GITHUB_OUTPUT
+                        gh pr diff $PR_NUMBER --name-only |grep '^lenskit.*\\.py$'
+                        if [ "$?" -eq 0 ]; then
+                            echo changed=true >>$GITHUB_OUTPUT
+                        else
+                            echo changed=false >>$GITHUB_OUTPUT
+                        fi
                     fi
                 """),
-                "env": {"GH_TOKEN": "${{ github.token }}"},
+                "env": {
+                    "GH_TOKEN": "${{ github.token }}",
+                    "PR_NUMBER": "${{ github.event.number }}",
+                },
             },
         ],
     }