Merge pull request #609 from mdekstrand/tweak/arm-ci

Add ARM and Windows vanilla Python to CI runs
lenskit · Jan 18, 2025 · 01907a8 · 01907a8
2 parents 48a4fec + 08d138c
commit 01907a8
Show file tree

Hide file tree

Showing 6 changed files with 5,172 additions and 1,655 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -38,11 +38,9 @@ jobs:
           - py313
         platform:
           - ubuntu-latest
+          - ubuntu-24.04-arm
           - macos-latest
           - windows-latest
-        exclude:
-          - python: py313
-            platform: windows-latest
     steps:
       - name: "🛒 Checkout"
         uses: actions/checkout@v4
@@ -91,10 +89,16 @@ jobs:
           - '3.13'
         platform:
           - ubuntu-latest
+          - ubuntu-24.04-arm
           - macos-latest
+          - windows-latest
         exclude:
           - python: '3.13'
             platform: macos-latest
+          - python: '3.13'
+            platform: windows-latest
+          - python: '3.13'
+            platform: ubuntu-24.04-arm
     steps:
       - name: "🛒 Checkout"
         uses: actions/checkout@v4

diff --git a/lenskit/lenskit/logging/monitor.py b/lenskit/lenskit/logging/monitor.py
@@ -146,7 +146,7 @@ def _log_sock(self) -> tuple[str, zmq.Socket[bytes]]:
             addr = f"ipc://{path}"
             sock.bind(addr)
         else:
-            port = sock.bind_to_random_port("127.0.0.1")
+            port = sock.bind_to_random_port("tcp://127.0.0.1")
             addr = f"tcp://127.0.0.1:{port}"
         log = _log.bind(address=addr)
         log.debug("bound listener socket")