Merge pull request #122 from dw-0/fix/MYPY-120

fix: ActionUpdateThread deprecation warnings
leinardi · Oct 4, 2024 · 7c6576b · 7c6576b
2 parents 410d620 + eae3833
commit 7c6576b
Show file tree

Hide file tree

Showing 16 changed files with 131 additions and 26 deletions.
diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/BaseAction.java b/src/main/java/com/leinardi/pycharm/mypy/actions/BaseAction.java
@@ -16,7 +16,6 @@
 
 package com.leinardi.pycharm.mypy.actions;
 
-import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.diagnostic.Logger;
@@ -79,11 +78,6 @@ public void update(final @NotNull AnActionEvent event) {
         }
     }
 
-    @Override
-    public @NotNull ActionUpdateThread getActionUpdateThread() {
-        return ActionUpdateThread.EDT;
-    }
-
     protected void setProgressText(final ToolWindow toolWindow, final String progressTextKey) {
         actOnToolWindowPanel(toolWindow, panel -> panel.setProgressText(MypyBundle.message(progressTextKey)));
     }

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ClearAll.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ClearAll.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.leinardi.pycharm.mypy.toolwindow.MypyToolWindowPanel;
 import org.jetbrains.annotations.NotNull;
@@ -28,6 +32,11 @@
  */
 public class ClearAll extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> actOnToolWindowPanel(toolWindow(project),

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/Close.java b/src/main/java/com/leinardi/pycharm/mypy/actions/Close.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import org.jetbrains.annotations.NotNull;
 
@@ -26,6 +30,11 @@
  */
 public class Close extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> toolWindow(project).hide(null));

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/CollapseAll.java b/src/main/java/com/leinardi/pycharm/mypy/actions/CollapseAll.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.leinardi.pycharm.mypy.toolwindow.MypyToolWindowPanel;
 import org.jetbrains.annotations.NotNull;
@@ -28,6 +32,11 @@
  */
 public class CollapseAll extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> actOnToolWindowPanel(toolWindow(project),

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayErrors.java b/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayErrors.java
@@ -12,6 +12,9 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
@@ -34,6 +37,11 @@
  */
 public class DisplayErrors extends DumbAwareToggleAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public boolean isSelected(final @NotNull AnActionEvent event) {
         final Project project = getEventProject(event);
@@ -58,9 +66,4 @@ public void setSelected(final @NotNull AnActionEvent event, final boolean select
             panel.filterDisplayedResults();
         });
     }
-
-    @Override
-    public @NotNull ActionUpdateThread getActionUpdateThread() {
-        return ActionUpdateThread.EDT;
-    }
 }
diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayNote.java b/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayNote.java
@@ -12,6 +12,9 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
@@ -35,6 +38,11 @@
  */
 public class DisplayNote extends DumbAwareToggleAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public boolean isSelected(final AnActionEvent event) {
         final Project project = PlatformDataKeys.PROJECT.getData(event.getDataContext());
@@ -59,9 +67,4 @@ public void setSelected(final @NotNull AnActionEvent event, final boolean select
             panel.filterDisplayedResults();
         });
     }
-
-    @Override
-    public @NotNull ActionUpdateThread getActionUpdateThread() {
-        return ActionUpdateThread.EDT;
-    }
 }
diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayWarnings.java b/src/main/java/com/leinardi/pycharm/mypy/actions/DisplayWarnings.java
@@ -12,6 +12,9 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
@@ -34,6 +37,11 @@
  */
 public class DisplayWarnings extends DumbAwareToggleAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public boolean isSelected(final @NotNull AnActionEvent event) {
         final Project project = getEventProject(event);
@@ -58,9 +66,4 @@ public void setSelected(final @NotNull AnActionEvent event, final boolean select
             panel.filterDisplayedResults();
         });
     }
-
-    @Override
-    public @NotNull ActionUpdateThread getActionUpdateThread() {
-        return ActionUpdateThread.EDT;
-    }
 }
diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ExpandAll.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ExpandAll.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.leinardi.pycharm.mypy.toolwindow.MypyToolWindowPanel;
 import org.jetbrains.annotations.NotNull;
@@ -28,6 +32,11 @@
  */
 public class ExpandAll extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> actOnToolWindowPanel(toolWindow(project), MypyToolWindowPanel::expandTree));

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScanCurrentChangeList.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScanCurrentChangeList.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.diagnostic.Logger;
@@ -39,6 +43,11 @@ public class ScanCurrentChangeList extends BaseAction {
 
     private static final Logger LOG = Logger.getInstance(ScanCurrentChangeList.class);
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.BGT;
+    }
+
     @Override
     public final void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> {

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScanCurrentFile.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScanCurrentFile.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.editor.Editor;
@@ -37,6 +41,11 @@
  */
 public class ScanCurrentFile extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.BGT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> {

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScanModifiedFiles.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScanModifiedFiles.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.diagnostic.Logger;
@@ -36,6 +40,11 @@ public class ScanModifiedFiles extends BaseAction {
 
     private static final Logger LOG = Logger.getInstance(ScanModifiedFiles.class);
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.BGT;
+    }
+
     @Override
     public final void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> {

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScanModule.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScanModule.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.application.ReadAction;
@@ -39,6 +43,11 @@
  */
 public class ScanModule extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.BGT;
+    }
+
     @Override
     public final void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> {

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScanProject.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScanProject.java
@@ -12,10 +12,14 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
 
+import com.intellij.openapi.actionSystem.ActionUpdateThread;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.Presentation;
 import com.intellij.openapi.application.ReadAction;
@@ -33,6 +37,11 @@
  */
 public class ScanProject extends BaseAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.BGT;
+    }
+
     @Override
     public void actionPerformed(final @NotNull AnActionEvent event) {
         project(event).ifPresent(project -> {

diff --git a/src/main/java/com/leinardi/pycharm/mypy/actions/ScrollToSource.java b/src/main/java/com/leinardi/pycharm/mypy/actions/ScrollToSource.java
@@ -12,6 +12,9 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * Modifications:
+ * - 2024-10-03: Modified by Dominik Willner to fix ActionUpdateThread deprecation warnings.
  */
 
 package com.leinardi.pycharm.mypy.actions;
@@ -33,6 +36,11 @@
  */
 public final class ScrollToSource extends DumbAwareToggleAction {
 
+    @Override
+    public @NotNull ActionUpdateThread getActionUpdateThread() {
+        return ActionUpdateThread.EDT;
+    }
+
     @Override
     public boolean isSelected(final AnActionEvent event) {
         final Project project = PlatformDataKeys.PROJECT.getData(event.getDataContext());
@@ -78,9 +86,4 @@ public void setSelected(final AnActionEvent event, final boolean selected) {
             ((MypyToolWindowPanel) content.getComponent()).setScrollToSource(selected);
         }
     }
-
-    @Override
-    public @NotNull ActionUpdateThread getActionUpdateThread() {
-        return ActionUpdateThread.EDT;
-    }
 }