-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mount): add log on Windows notification area #280
Conversation
2356a23
to
be95c08
Compare
5330666
to
e80b2cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @rolysr. Please, see my suggestions.
bfa1f5a
to
0bd5a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
9375aba
to
e3fabec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
0bef4e9
to
f38e83b
Compare
This change adds a log on the specific OS notification area, specifically for errors associated with the reading, writing and master disconnection processes, which allows the user to have a proper feedback on the each error. Signed-off-by: rolysr <rolysr@leil.io>
f38e83b
to
4e24711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @rolysr 👍 💪 🔥
This change adds a log on the specific OS notification area, specifically for errors associated with the reading, writing and master disconnection processes, which allows the user to have a proper feedback on the each error. Signed-off-by: rolysr <rolysr@leil.io>
This change adds a log on the specific OS notification area, specifically for errors associated with the reading, writing and master disconnection processes, which allows the user to have a proper feedback on the each error. Signed-off-by: rolysr <rolysr@leil.io>
This change adds a log on Windows notification area, specifically for the error associated with the writing process, which allows the user to have a proper feedback on the error on the Windows environment. This is a Windows-specific feature.