Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mount): add log on Windows notification area #280

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

rolysr
Copy link
Collaborator

@rolysr rolysr commented Jan 12, 2025

This change adds a log on Windows notification area, specifically for the error associated with the writing process, which allows the user to have a proper feedback on the error on the Windows environment. This is a Windows-specific feature.

@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch 5 times, most recently from 2356a23 to be95c08 Compare January 14, 2025 18:53
src/mount/fuse/main.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Show resolved Hide resolved
src/mount/writedata.cc Outdated Show resolved Hide resolved
@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch 4 times, most recently from 5330666 to e80b2cb Compare January 30, 2025 11:41
Copy link
Contributor

@ralcolea ralcolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @rolysr. Please, see my suggestions.

src/mount/notification_area_logging.h Outdated Show resolved Hide resolved
src/mount/notification_area_logging.h Outdated Show resolved Hide resolved
src/mount/notification_area_logging.h Outdated Show resolved Hide resolved
src/mount/notification_area_logging.h Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/readdata.cc Outdated Show resolved Hide resolved
src/mount/sauna_client.h Outdated Show resolved Hide resolved
src/mount/sauna_client.h Outdated Show resolved Hide resolved
src/mount/writedata.cc Outdated Show resolved Hide resolved
@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch 2 times, most recently from bfa1f5a to 0bd5a40 Compare February 4, 2025 00:05
Copy link
Contributor

@ralcolea ralcolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch 2 times, most recently from 9375aba to e3fabec Compare February 4, 2025 23:44
Copy link
Collaborator

@dmga44 dmga44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

src/mount/fuse/mount_config.cc Outdated Show resolved Hide resolved
@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch 2 times, most recently from 0bef4e9 to f38e83b Compare February 5, 2025 10:39
This change adds a log on the specific OS notification area,
specifically for errors associated with the reading, writing and master
disconnection processes, which allows the user to have a proper feedback
on the each error.

Signed-off-by: rolysr <rolysr@leil.io>
@rolysr rolysr force-pushed the add-err-log-windows-notification-area branch from f38e83b to 4e24711 Compare February 6, 2025 12:15
Copy link
Contributor

@ralcolea ralcolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @rolysr 👍 💪 🔥

@rolysr rolysr merged commit c929148 into dev Feb 6, 2025
5 checks passed
@rolysr rolysr deleted the add-err-log-windows-notification-area branch February 6, 2025 19:04
rolysr added a commit that referenced this pull request Feb 6, 2025
This change adds a log on the specific OS notification area,
specifically for errors associated with the reading, writing and master
disconnection processes, which allows the user to have a proper feedback
on the each error.

Signed-off-by: rolysr <rolysr@leil.io>
rolysr added a commit that referenced this pull request Feb 7, 2025
This change adds a log on the specific OS notification area,
specifically for errors associated with the reading, writing and master
disconnection processes, which allows the user to have a proper feedback
on the each error.

Signed-off-by: rolysr <rolysr@leil.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants