Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with source #1

Merged
merged 4 commits into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .envrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use flake
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
- '3.3'
- jruby
gemfiles:
- gemfiles/Gemfile-rspec-3.11.x
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## [Unreleased]

## [4.4.1] - 2024-08-09

### Fixed

- Fix tags on scenario outline [[GH-252](https://github.com/jnicklas/turnip/pull/252)]

## [4.4.0] - 2022-11-04

### Added
Expand Down
12 changes: 12 additions & 0 deletions examples/tags.feature
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,15 @@ Feature: With tags
When I attack it
And I attack it
Then it should die

@variety
Scenario Outline: With tag on scenario outline
Given there is a <Monster Type> monster
When I attack it
And I attack it
Then it should die

Examples:
| Monster Type |
| weak |
| strong |
24 changes: 24 additions & 0 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
description = "Ruby dev environment";

inputs = { };

outputs = { self, nixpkgs }:
let
# Helper to provide system-specific attributes
forAllSupportedSystems = f: nixpkgs.lib.genAttrs supportedSystems (system: f {
pkgs = import nixpkgs { inherit system; };
});

supportedSystems = [
"aarch64-darwin"
"aarch64-linux"
"x86_64-darwin"
"x86_64-linux"
];
in

{
devShells = forAllSupportedSystems ({ pkgs }: {
default = pkgs.mkShell {
packages = with pkgs; [
ruby_3_2
];
};
});
};
}
1 change: 1 addition & 0 deletions lib/turnip/node/scenario_outline.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def convert_metadata_to_scenario(header, row)
scenario.steps = original.steps
scenario.source_line = original.source_line
scenario.source_column = original.source_column
scenario.tags = original.tags
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/turnip/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Turnip
VERSION = '4.4.0'
VERSION = '4.4.1'
end
2 changes: 2 additions & 0 deletions spec/builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@
expect(feature.tags[0]).to be_instance_of Turnip::Node::Tag
expect(feature.scenarios[0].tags[0].name).to eq 'cool'
expect(feature.scenarios[1].tag_names).to eq ['stealthy', 'wicked']
expect(feature.scenarios[2].tag_names).to eq ['variety']
expect(feature.scenarios[3].tag_names).to eq ['variety']
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
end

it "prints out failures and successes" do
@result.should include('46 examples, 4 failures, 6 pending')
@result.should include('48 examples, 4 failures, 7 pending')
end

it "includes features in backtraces" do
Expand Down
Loading