Enable unequal width and height of the input #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an error encountered when unequal input width and height are specified (e.g. 320x224). The goal is to use the full field of view of the camera instead of the square center crop.
With the original version, simply changing the input dimensions in the parameters leads to errors with tensors dimensions, e.g.
RuntimeError: shape '[224, 320, -1]' is invalid for input of size 4566016.This PR fixes the error and enables using unequal dimensions of the input (the dimensions still need to be divisible by the patch size).
Tested on the robot and with the Jackal simulation demo.