feat: add darkmode to site and add theme prop #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One point to note is that the DarkHighlightMode feature is configured to automatically activate with the site's dark mode setting. |
|
closes #266 |
leezng
reviewed
Feb 1, 2024
Dan0xE
changed the title
leezng
approved these changes
Feb 2, 2024
|
Will you update the npm package? This was merged 2 weeks ago but npm says last updated 2 months ago? |
|
I second this notion. Could you publish this when you find the time, please? Would love to use this in my project, but it features darkmode and this makes it sadly hard to use. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the integration of Dark Mode support for the Vue-Pretty-JSON website. Additionally, it incorporates a new property, darkHighlightMode.
Rationale for the Change:
The primary motivation for this enhancement is to address the aesthetic challenges encountered when using Vue-Pretty-JSON on a dark background. Previously, the hover effect still showed a bright blue which made the text unreadable.
To resolve this issue, the pull request implements the darkHighlightMode, which now displays a dark blue on dark backgrounds, as demonstrated in the following image:
Since no other components seem to require an adjustment to work with darkmode, i've limited it to only the hover effect.