Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support collapsedNodeLength for vue2 #259

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: support collapsedNodeLength for vue2 #259

merged 1 commit into from
Nov 23, 2023

Conversation

boukadam
Copy link
Contributor

for #258

@leezng
Copy link
Owner

leezng commented Nov 22, 2023

@boukadam
Thanks for the PR, this feature looks great. I have some suggestions:

  1. Can the prop name be changed to collapsedNodeLength? This looks closer to the meaning of use.
  2. Can you help me submit it to vue3 version? Merge into dev branch.

@boukadam
Copy link
Contributor Author

Hi @leezng, okay for the prop name, i’ll change it. Also, i’ll open another PR into dev branch for Vue3.

@leezng leezng merged commit 7460b87 into leezng:1.x Nov 23, 2023
1 check passed
@leezng leezng changed the title feat: add collapse threshold feat: support collapsedNodeLength for vue2 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezng leezng leezng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boukadam @leezng