Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MicroPather::Reset() #21

Open
randomMesh opened this issue Jan 15, 2021 · 0 comments
Open

Rename MicroPather::Reset() #21

randomMesh opened this issue Jan 15, 2021 · 0 comments

Comments

@randomMesh
Copy link

randomMesh commented Jan 15, 2021

When using MicroPather in a modern application using std::unique_ptr, the Reset method could easily be confused with the reset method of the smart pointer.

std::unique_ptr<micropather::MicroPather> pather;

// costs between states changed
pather->Reset();

// delete the pointer explicitly
pather.reset();

I therefore suggest to rename the Reset method to StateCostChanged or similar.
You should keep Reset and use it as a wrapper for the new method in order to keep backwards compatibility, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant