Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Custom Start Degree with Numbering Position #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seanalexander
Copy link

Summary:
This PR introduces a feature that automatically synchronizes the Custom Start Degree field with the Numbering Position. When a user selects a numbering position (Top, Left, Right, Bottom), the corresponding angle (0, 90, 180, 270 degrees) is automatically set in the Custom Start Degree input, ensuring consistent behavior between the two options.

Changes:

  • Added logic to update Custom Start Degree based on the selected Numbering Position if no custom degree is manually set.
  • Numbering Position angles:
    • Top: 90 degrees
    • Left: 180 degrees
    • Right: 0 degrees
    • Bottom: 270 degrees
  • Custom Start Degree remains flexible and can be overridden by the user if needed.

Impact:

  • Improves usability by ensuring that the Custom Start Degree automatically reflects changes made via Numbering Position selection.
  • Prevents confusion by keeping the two options synchronized while preserving manual overrides when necessary.

Testing:

  • Tested functionality where selecting different Numbering Positions correctly updates the Custom Start Degree.
  • Confirmed that manually setting Custom Start Degree still works as expected, overriding the numbering position when needed.

danielbolan and others added 3 commits October 9, 2024 12:47
feat: Sync Custom Start Degree with Numbering Position

- Added logic to automatically update the Custom Start Degree when the Numbering Position is selected, ensuring synchronization between the two options.
- Custom Start Degree now reflects the corresponding angle (0, 90, 180, or 270 degrees) based on the chosen Numbering Position (Top, Left, Right, Bottom).
- Preserved flexibility: Custom Start Degree can still be manually overridden by the user.
@leechwort
Copy link
Owner

Hi! Thank you for your contribution, I will check your PR asap!

@leechwort
Copy link
Owner

Hi @seanalexander! I'm testing your PR on my side, here is what I've got.
Settings "Top", "Left" and "Bottom" work fine:

Top Left Bottom
image image image

Setting "Right" looks weird:
image
Can you check this on your side? Here are screenshots of all settings:

s1 s2 s3
image image image

My inkscape version: Inkscape 1.3.2 (1:1.3.2+202404261509+091e20ef0f) on linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants